On 12.09.12 11:50:57, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 12, 2012 at 07:46:55PM +0200, Robert Richter escreveu: > > On 12.09.12 09:16:28, David Ahern wrote: > > > > > > Kernel side AMD currently ignores all exclude_* bits, so there is no > > > impact > > > to existing IBS code paths. Robert Richter has a patch where IBS code will > > > return EINVAL if an exclude_* bit is set. When this goes in it means use > > > of :p on AMD with IBS will first fail with EINVAL (because exclude_guest > > > will be set). Then the existing fallback code within perf will unset > > > exclude_guest and try again. The second attempt will succeed if the CPU > > > supports IBS profiling. > > > > > > Signed-off-by: David Ahern <dsah...@gmail.com> > > > Cc: Ingo Molnar <mi...@kernel.org> > > > Cc: Peter Zijlstra <pet...@infradead.org> > > > Cc: Robert Richter <robert.rich...@amd.com> > > > Cc: Gleb Natapov <g...@redhat.com> > > > Cc: Avi Kivity <a...@redhat.com> > > > Link: https://lkml.org/lkml/2012/7/9/264 > > > --- > > > tools/perf/util/parse-events.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > Acked-by: Robert Richter <robert.rich...@amd.com> > > > > I tested the patch set with AMD IBS and it works fine. > > Ok, I think that in this specific patchset I can add: > > Tested-by: Robert Richter <robert.rich...@amd.com> > Reviewed-by: Robert Richter <robert.rich...@amd.com> > > Instead of an Acked-by, may I?
I am fine with this. Thanks, -Robert > > - Arnaldo > -- Advanced Micro Devices, Inc. Operating System Research Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
