> +static int pty_get_lock(struct tty_struct *tty, int __user *arg) > +{ > + int locked = test_bit(TTY_PTY_LOCK, &tty->flags); > + if (put_user(locked, arg)) > + return -EFAULT;
Now explain exactly how this doesn't race with another thread chanigng the lock setting ? The other comment I have is that it might be better put these in now there are sysfs patches for the tty layer bouncing about to provide the needed infrastructure ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/