On Sep 13, 2012, at 3:14 AM, Ian Campbell wrote:
> On Wed, 2012-09-12 at 20:45 +0100, Andres Lagar-Cavilla wrote:
>> diff --git a/include/xen/interface/grant_table.h
>> b/include/xen/interface/grant_table.h
>> index 7da811b..66cb734 100644
>> --- a/include/xen/interface/grant_table.h
>> +++ b/include/xen/interface/grant_table.h
>> @@ -520,6 +520,7 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_get_version);
>> #define GNTST_permission_denied (-8) /* Not enough privilege for operation.
>> */
>> #define GNTST_bad_page (-9) /* Specified page was invalid for op.
>> */
>> #define GNTST_bad_copy_arg (-10) /* copy arguments cross page boundary */
>
> What is -11?
-11 is something called GNTST_address_too_big on the xen public includes. Since
it is not relevant too this patch I decided to skip over it. I will add a
"placeholder" entry to the message array below to keep things properly aligned.
Thanks
Andres
>
> Because...
>
>> +#define GNTST_eagain (-12) /* Retry.
>> */
>>
>> #define GNTTABOP_error_msgs { \
>> "okay", \
>> @@ -533,6 +534,7 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_get_version);
>> "permission denied", \
>> "bad page", \
>> "copy arguments cross page boundary" \
>
> ... it should go here, otherwise retry is in the wrong place.
>
> Perhaps we should switch this to the
> [GNTTABOP_foo] = "foo"
> style of initialiser?
>
>> + "retry" \
>> }
>>
>> #endif /* __XEN_PUBLIC_GRANT_TABLE_H__ */
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
