On 09/18, Roland McGrath wrote: > > > But, somehow I forgot about compat tasks when we discussed this before. > > Perhaps the code above should do > > > > if (is_compat_task()) > > copy_siginfo_to_user32(...); > > else > > copy_siginfo_to_user(...); > > > > ? > > compat_binfmt_elf.c will define a separate copy of this code via #include. > So it just needs #define copy_siginfo_to_user copy_siginfo_to_user32 or > something like that, as the various other types and functions are handled.
Ah, yes, you are right. Much better. But. It seems, it also needs to do s/siginfo_t/compat_siginfo/ somehow, a simple '#define' obviously can't work. IOW, elf_thread_core_info.signote should be either siginfo_t or compat_siginfo, but the argument passed to ->core_dump() and callees should be siginfo_t. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
