> @@ -147,7 +148,7 @@ u64 arch_irq_stat_cpu(unsigned int cpu) > #ifdef CONFIG_SMP > sum += irq_stats(cpu)->irq_resched_count; > sum += irq_stats(cpu)->irq_call_count; > - sum += irq_stats(cpu)->irq_tlb_count; > + /* irq_tlb_count is already added to irq_call_count */
redundant comments here? > #endif > #ifdef CONFIG_X86_THERMAL_VECTOR > sum += irq_stats(cpu)->irq_thermal_count; > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index 613cd83..0a054db 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -98,6 +98,9 @@ static void flush_tlb_func(void *info) > { > struct flush_tlb_info *f = info; > > + /* irq_call_cnt is also incremented; be subtracted on display */ If is it better to move above explanation to irq_call_cnt definition place: harirq.h? > + inc_irq_stat(irq_tlb_count); > + > if (f->flush_mm != this_cpu_read(cpu_tlbstate.active_mm)) > return; > > -- Thanks Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/