On Fri, Sep 21, 2012 at 01:16:38AM +0100, Paul Parsons wrote: > >>When I reboot my iPAQ hx4700 in its cradle, the battery will not begin > >>to charge even though the AC supply is connected. Charging will start > >>only after the PDA power driver is tickled by some other power event, > >>such as reseating the iPAQ in its cradle or connecting the USB cable. > >> > >>The problem lies in pda_power_probe(), where ac_draw is used by the call > >>to update_charger() before being set by the call to regulator_get(). > >> > >>Moving the regulator_get() call to before the update_charger() call > >>fixes the problem. > >> > >>Signed-off-by: Paul Parsons <lost.dista...@yahoo.com> > >>Cc: Philipp Zabel <philipp.za...@gmail.com> > >>--- > > > >Great to see that someone is still using hx4700. :-) > > > >Thanks for the patch, it is merged now! > > I am having second thoughts about the goto ac_draw_failed I added. > This will cause pda_power_probe() to fail if regulator_get() fails. > However the way ac_draw is used - always after a check for NULL - > suggests that a failed call to regulator_get() was not fatal. > > I am happy to submit another patch to remove the goto and label.
Sure thing, just send another patch on top. Thanks! Anton. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
