On Thu, Sep 20, 2012 at 7:32 PM, <[email protected]> wrote: > From: Sjur Brændeland <[email protected]> > > Add support for the STE modem shared memory driver. > This driver hooks into the remoteproc framework > in order to manage configuration and the virtio > devices. > > This driver adds custom firmware handlers, because > STE modem uses a custom firmware layout. > > Signed-off-by: Sjur Brændeland <[email protected]> > cc: Linus Walleij <[email protected]> > cc: Alan Cox <[email protected]> > --- > Changes from v3: > Added function setup to struct ste_modem_dev_ops.
Thanks, it looks good. It might be safer though to invoke ->setup() in probe/remove, instead of in start/stop (just like you essentially did before). This way we don't assume that stop is always called before remove (as assumption that might be implicitly valid today, but may break in the future). If you want, I can just change that before applying. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
