Hi Rui, > > > Hi, Jonghwa, > > > > > > I still do not understand what the problem is. > > > Say if a cooling device fails to bind, the thermal zone device would > > > still work properly, just like the failure cooling device is not > > > referenced in this thermal zone. > > > > > > thanks, > > > rui > > Hi rui, > > No, it doesn't work properly. If it fails to bind some cool dev to > > thermal zone device, it frees thermal zone > > device without canceling delayed work. After freeing thermal zone > > device, system may call work function > > pointed NULL as the timer expired. Thus it requires skipping the > > initialization of polling work or canceling before > > the unregister. > > > hah, I see what the problem is. > ideally, if we fail to bind one cooling device, we should just ignore it > and continue to bind other, what do you think?
Yes, this is what we should do. > > does the patch below fix your problem? > If yes, I'll try to rebase it on top of my next tree. This is already fixed in your -next tree, since you applied the fair share patches 10/15. The function bind_tz(tz) does the exact same thing, and continues. Thanks, Durga
