On Tue, Sep 25, 2012 at 03:22:04AM +0200, Sebastian Hesselbarth wrote: > On 09/25/2012 02:02 AM, Sebastian Hesselbarth wrote: > >During the review process of dove DT patches, Tauros2 cache > >init call was changed and DT support added. This patch fixes > >the call to Tauros2 init and adds a DT node. Moreover, plat/irq.h > >include was missing from mach-dove/common.c. > > ... > >diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c > >index b37bef1..343a4bc 100644 > >--- a/arch/arm/mach-dove/common.c > >+++ b/arch/arm/mach-dove/common.c > >@@ -32,6 +32,7 @@ > > #include<linux/irq.h> > > #include<plat/time.h> > > #include<linux/platform_data/usb-ehci-orion.h> > >+#include<plat/irq.h> > > #include<plat/common.h> > > #include<plat/addr-map.h> > > #include "common.h" > >@@ -399,7 +400,7 @@ static void __init dove_dt_init(void) > > (dove_tclk + 499999) / 1000000); > > > > #ifdef CONFIG_CACHE_TAUROS2 > >- tauros2_init(); > >+ tauros2_init(0); > > #endif > > dove_setup_cpu_mbus(); > > > > I thought about the importance of the individual patches and > except 2/6 all can wait for the next release cycle if too late. > > But 2/6 is important because the change in tauros2_init > breaks build on dove.
Hi Sebastian Interestingly, kisskb does not show this break: http://kisskb.ellerman.id.au/kisskb/config/308/ and yesterdays build does not have the parameter to tauros2_init(). Is the cache not enabled in dove_defconfig? Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
