On Tue, Sep 25, 2012 at 04:03:38PM +0530, Shubhrajyoti D wrote:
> Convert the struct i2c_msg initialization to C99 format. This makes
> maintaining and editing the code simpler. Also helps once other fields
> like transferred are added in future.
>
> Signed-off-by: Shubhrajyoti D <shubhrajy...@ti.com>
> ---
> drivers/rtc/rtc-ds1672.c | 26 ++++++++++++++++++++++----
> 1 files changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c
> index 7fa67d0..577dbae 100644
> --- a/drivers/rtc/rtc-ds1672.c
> +++ b/drivers/rtc/rtc-ds1672.c
> @@ -37,8 +37,17 @@ static int ds1672_get_datetime(struct i2c_client *client,
> struct rtc_time *tm)
> unsigned char buf[4];
>
> struct i2c_msg msgs[] = {
> - {client->addr, 0, 1, &addr}, /* setup read ptr */
> - {client->addr, I2C_M_RD, 4, buf}, /* read date */
> + {/* setup read ptr */
> + .addr = client->addr,
> + .len = 1,
> + .buf = &addr
> + },
> + {/* setup read ptr */should this comment be /* read date */ ?? -- balbi
signature.asc
Description: Digital signature
