On Wed, Sep 26, 2012 at 9:51 AM, viresh kumar <[email protected]> wrote: > On Wed, Sep 26, 2012 at 12:17 PM, Andy Shevchenko > <[email protected]> wrote: > >> This separate driver makes no sense in case it is built properly without >> CLK framework. Let me check this and leave comments at patch 1/6. > > Following is the commit that introduced this change :) Thanks for pointing to it
> > commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1 > Author: Viresh Kumar <[email protected]> > Date: Mon Jul 30 14:39:27 2012 -0700 A-ha, this explains: Heikki's patches are stamped as follows commit 7c33a7ec5f1f68c1ab06eee7ff7118a7b62db5da Author: Heikki Krogerus <[email protected]> Date: Mon May 7 12:31:29 2012 +0300 > > clk: add non CONFIG_HAVE_CLK routines > > Many drivers are shared between architectures that may or may not have > HAVE_CLK selected for them. To remove compilation errors for them we > enclose clk_*() calls in these drivers within #ifdef CONFIG_HAVE_CLK, > #endif. > > This patch removes the need of these CONFIG_HAVE_CLK statements, by > introducing dummy routines when HAVE_CLK is not selected by platforms. > So, definition of these routines will always be available. These calls > will return error for platforms that don't select HAVE_CLK. > > Signed-off-by: Viresh Kumar <[email protected]> > Cc: Wolfram Sang <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Jeff Garzik <[email protected]> > Cc: Andrew Lunn <[email protected]> > Cc: Bhupesh Sharma <[email protected]> > Cc: Giuseppe Cavallaro <[email protected]> > Cc: Russell King <[email protected]> > Cc: Mike Turquette <[email protected]> > Cc: Sergei Shtylyov <[email protected]> > Cc: viresh kumar <[email protected]> > Signed-off-by: Andrew Morton <[email protected]> > Signed-off-by: Linus Torvalds <[email protected]> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
