* Tao Guo <glorious...@gmail.com> wrote:
> On Wed, Sep 26, 2012 at 9:25 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> > On Wed, Sep 26, 2012 at 04:28:22AM -0400, Tao Guo wrote:
> >> gas in binutils(2.16.91) could not parse parentheses within macro
> >> parameters unless fully parenthesized, and this is a workaround to
> >> make old gas work without generating below errors:
> >> arch/x86/kernel/entry_64.S: Assembler messages:
> >> arch/x86/kernel/entry_64.S:387: Error: too many positional arguments
> >> arch/x86/kernel/entry_64.S:389: Error: too many positional arguments
> >> arch/x86/kernel/entry_64.S:390: Error: too many positional arguments
> >> arch/x86/kernel/entry_64.S:391: Error: too many positional arguments
> >> arch/x86/kernel/entry_64.S:392: Error: too many positional arguments
> >> arch/x86/kernel/entry_64.S:393: Error: too many positional arguments
> >> arch/x86/kernel/entry_64.S:394: Error: too many positional arguments
> >>
> >> Signed-off-by: Tao Guo <glorious...@gmail.com>
> >> ---
> >> arch/x86/include/asm/calling.h | 48
> >> +++++++++++++++++++--------------------
> >> arch/x86/kernel/entry_64.S | 20 ++++++++--------
> >> 2 files changed, 33 insertions(+), 35 deletions(-)
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
> >
> > </formletter>
>
> Thanks Greg, I just realized that I followed the old rules in
> an old Documentation/stable_kernel_rules.txt file. Since the
> patches for other stable branches will be a little different
> from this one, I will send them later to
> sta...@vger.kernel.org after this patch gets accepted.
Please don't send this to -stale yet (or at all).
I have queued up the patch for v3.7, not even for v3.6. It needs
more testing - old GAS users are probably better off having a
non-building kernel than a subtly broken one. v3.7 and onwards
stable kernels will have the fix - hopefully by the time it's
released any more subtle bugs are found and fixed.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
