On Thu, 27 Sep 2012 13:09:24 +0200, Jiri Olsa wrote: > Currently the overhead and baseline columns are handled within > single function and the distinction is made by 'baseline hists' > pointer passed by 'struct perf_hpp::ptr'. > > Since hists pointer is now part of each hist_entry, it's possible > to locate paired hists pointer directly from the passed struct > hist_entry pointer. > > Also separating those 2 columns makes the code more obvious.
Yes, it was thinking about something like this. > > Cc: Arnaldo Carvalho de Melo <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: Corey Ashford <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > Cc: Namhyung Kim <[email protected]> > Signed-off-by: Jiri Olsa <[email protected]> > --- [snip] > +static int hpp__color_baseline(struct perf_hpp *hpp, struct hist_entry *he) > +{ > + double percent = baseline_percent(he); > + > + return percent_color_snprintf(hpp->buf, hpp->size, " %5.2f%%", > percent); Is it possible to have a baseline value over 100%? I changed 'overhead' colum format from '2 spaces + %5.2f + %' to '1 space + %6.2f + %' for the case. Probably it'd better using it here too for consistency. > +} > + > +static int hpp__entry_baseline(struct perf_hpp *hpp, struct hist_entry *he) > +{ > + double percent = baseline_percent(he); > + const char *fmt = symbol_conf.field_sep ? "%.2f" : " %5.2f%%"; Ditto. Thanks, Namhyung > + > + return scnprintf(hpp->buf, hpp->size, fmt, percent); > +} > + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
