Re: 2.4.2-ac3: loop threads in D state

[Jens Axboe]

On Sun, Feb 25 2001, Nate Eldredge wrote:
> Nate Eldredge writes:
>  > Kernel 2.4.2-ac3.
>  > 
>  >  FLAGS   UID   PID  PPID PRI  NI   SIZE   RSS WCHAN       STA TTY TIME COMMAND
>  >     40     0   425     1  -1 -20      0     0 down        DW< ?   0:00 (loop0)
> 
> It looks like this has been addressed in the thread "242-ac3 loop
> bug".  Jens Axboe posted a patch, but the list archive I'm reading
> mangled it.  Jens, could you make this patch available somewhere, or
> at least email me a copy?  (If it's going in an upcoming -ac patch,
> then don't bother; I can wait until then.)

Patch is here, I haven't checked whether Alan put it in ac4 yet (I
did cc him, but noone knows for sure :-).

-- 
Jens Axboe


--- drivers/block/loop.c~       Sat Feb 24 23:08:38 2001
+++ drivers/block/loop.c        Sat Feb 24 23:11:13 2001
@@ -507,7 +507,7 @@
        sprintf(current->comm, "loop%d", lo->lo_number);
 
        spin_lock_irq(&current->sigmask_lock);
-       siginitsetinv(&current->blocked, sigmask(SIGKILL));
+       sigfillset(&current->blocked);
        flush_signals(current);
        spin_unlock_irq(&current->sigmask_lock);
 
@@ -525,7 +525,7 @@
        up(&lo->lo_sem);
 
        for (;;) {
-               down(&lo->lo_bh_mutex);
+               down_interruptible(&lo->lo_bh_mutex);
                if (!atomic_read(&lo->lo_pending))
                        break;