On Wed, Oct 03, 2012 at 12:21:32AM +0900, Namhyung Kim wrote: > The '_get_comp_words_by_ref' function is available from the bash > completion v1.2 so that earlier version emits following warning: > > $ perf re<TAB>_get_comp_words_by_ref: command not found > > Use older '_get_cword' method when the above function doesn't exist.
May be only use _get_cword then, if it works everywhere? > > Cc: Frederic Weisbecker <fweis...@gmail.com> > Cc: David Ahern <dsah...@gmail.com> > Signed-off-by: Namhyung Kim <namhy...@kernel.org> > --- > tools/perf/bash_completion | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/bash_completion b/tools/perf/bash_completion > index 1958fa539d0f..3d48cee1b5e5 100644 > --- a/tools/perf/bash_completion > +++ b/tools/perf/bash_completion > @@ -1,12 +1,23 @@ > # perf completion > > +function_exists() > +{ > + declare -F $1 > /dev/null > + return $? > +} > + > have perf && > _perf() > { > - local cur cmd > + local cur prev cmd > > COMPREPLY=() > - _get_comp_words_by_ref cur prev > + if function_exists _get_comp_words_by_ref; then > + _get_comp_words_by_ref cur prev > + else > + cur=$(_get_cword) > + prev=${COMP_WORDS[COMP_CWORD-1]} > + fi > > cmd=${COMP_WORDS[0]} > > -- > 1.7.9.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/