On Tue, Oct 02, 2012 at 06:45:36PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 02, 2012 at 03:10:49PM +0200, Jiri Olsa escreveu: > > On Tue, Oct 02, 2012 at 07:39:23AM -0400, Ben Guthro wrote: > > > Actually - I hadn't noticed these warnings before. > > > > After installing libdw-dev - the perf build completed successfully. > > > Perhaps this should be fatal, rather than a warning? > > > attached patch fixies the issue for me. Adding Arnaldo to the loop. > > [acme@sandy linux]$ make -j8 -C tools/perf/ LIBUNWIND_DIR=/opt/libunwind > O=/home/acme/git/build/perf install > cc1: warnings being treated as errors > arch/x86/util/dwarf-regs.c:72: error: no previous prototype for > ‘get_arch_regstr’ > make: *** [/home/acme/git/build/perf/arch/x86/util/dwarf-regs.o] Error 1 > make: *** Waiting for unfinished jobs.... > make: Leaving directory `/home/git/linux/tools/perf' > [acme@sandy linux]$ > > - Arnaldo
ugh.. forgot the way you build perf ;) (also smells like 'automated make test' adept) Anyway, there's Makefile dependency on PERF_HAVE_DWARF_REGS which is defined in arch/x86/Makefile. So, there's only one right place for '-include arch/$(ARCH)/Makefile'. We should think of some other solution, since this seems fragile. I checked your make and simple make with attached patch (only x86_64 arch, and with and without libdw installed). jirka --- We need to include arch Makefile after we decide the NO_DWARF, otherwise we get might get build failure. The reason is the arch Makefile could include objects based on the NO_DWARF value, as it is for x86 case. Cc: Peter Zijlstra <[email protected]> Cc: Frederic Weisbecker <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Arnaldo Carvalho de Melo <[email protected]> Signed-off-by: Jiri Olsa <[email protected]> --- tools/perf/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 6958ba4..c287c1d 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -505,8 +505,6 @@ ifneq ($(call try-cc,$(SOURCE_LIBUNWIND),$(FLAGS_UNWIND)),y) endif # Libunwind support endif # NO_LIBUNWIND --include arch/$(ARCH)/Makefile - ifneq ($(OUTPUT),) BASIC_CFLAGS += -I$(OUTPUT) endif @@ -539,6 +537,8 @@ ifneq ($(call try-cc,$(SOURCE_DWARF),$(FLAGS_DWARF)),y) NO_DWARF := 1 endif # Dwarf support +-include arch/$(ARCH)/Makefile + ifndef NO_DWARF ifeq ($(origin PERF_HAVE_DWARF_REGS), undefined) msg := $(warning DWARF register mappings have not been defined for architecture $(ARCH), DWARF support disabled); -- 1.7.11.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
