On Fri, Oct 5, 2012 at 6:15 PM, Ian Abbott <[email protected]> wrote: > On 2012-10-05 01:07, YAMANE Toshiaki wrote: >> >> fixed below checkpatch warning. >> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then >> pr_err(... to printk(KERN_ERR ... >> >> Signed-off-by: YAMANE Toshiaki <[email protected]> >> --- >> drivers/staging/comedi/drivers/adl_pci8164.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/adl_pci8164.c >> b/drivers/staging/comedi/drivers/adl_pci8164.c >> index 05e06e7..6dbe465 100644 >> --- a/drivers/staging/comedi/drivers/adl_pci8164.c >> +++ b/drivers/staging/comedi/drivers/adl_pci8164.c >> @@ -89,9 +89,9 @@ static void adl_pci8164_insn_read(struct comedi_device >> *dev, >> } >> >> data[0] = inw(dev->iobase + axis_reg + offset); >> - printk(KERN_DEBUG "comedi: pci8164 %s read -> " >> - "%04X:%04X on axis >> %s\n", >> - action, data[0], data[1], axisname); >> + dev_dbg(dev->class_dev, >> + "comedi: pci8164 %s read -> %04X:%04X on axis %s\n", >> + action, data[0], data[1], axisname); >> } > > > The "comedi: " prefix is superfluous, so should be removed. The dev_dbg() > call will emit the word "comedi" twice already without the extra prefix. > > >> >> static int adl_pci8164_insn_read_msts(struct comedi_device *dev, >> @@ -170,9 +170,9 @@ static void adl_pci8164_insn_out(struct comedi_device >> *dev, >> >> outw(data[0], dev->iobase + axis_reg + offset); >> >> - printk(KERN_DEBUG "comedi: pci8164 %s write -> " >> - "%04X:%04X on axis %s\n", >> - action, data[0], data[1], axisname); >> + dev_dbg(dev->class_dev, >> + "comedi: pci8164 %s write -> %04X:%04X on axis %s\n", >> + action, data[0], data[1], axisname); >> >> } > > > Same here.
Ian-san, Thank you for pointing out my mistakes. I will try to fix it. -- Regards, YAMANE Toshiaki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
