On Fri, 2012-10-05 at 16:50 +0200, Maxime Bizon wrote: > On Fri, 2012-10-05 at 15:02 +0200, Eric Dumazet wrote: > > > On Fri, 2012-10-05 at 14:51 +0200, Maxime Bizon wrote: > > > > > > New convention would be : pass number of needed bytes after current > > > > tail, not after current end. > > > > > > Fully agree on this > > > > > > > Here is the proposal : > > Looks fine > > What is your plan for the actual pskb_expand_head() code now that you > will have absolute values for headroom & tailroom ? >
They stay relative values. For example, netlink_trim() really wants to shrink the skb head. > Because there will still be callers that have no clue of required > tailroom (nor further headroom requirement), like skb_cow() in > vlan_reorder_header(). > What I plan is to not shrink size, unless specifically asked. Its 3.8 material anyway, so a stable fix is needed on skb_recycle() and NET_SKB_PAD minimal value. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
