On Wednesday 10 of October 2012 02:19:06 Igor Murzov wrote:
> This should fix brightness controls on some laptops.
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=47861
>
> Signed-off-by: Igor Murzov <e-m...@date.by>
Put more detials into the changelog, please. The BZ entry linked above
may or may not be accessible when the changelog is read by someone.
> ---
> drivers/acpi/video.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 1e0a9e1..01bb58d 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -1349,8 +1349,12 @@ acpi_video_bus_get_devices(struct acpi_video_bus
> *video,
> struct acpi_device *dev;
>
> status = acpi_video_device_enumerate(video);
> - if (status)
> - return status;
> + if (status) {
> + if (status == AE_AML_PACKAGE_LIMIT)
> + status = 0; /* Ignore this error */
> + else
> + return status;
> + }
First off, please add a comment explaining _why_ we're ignoring the error.
Second, what about adding just:
if (status == AE_AML_PACKAGE_LIMIT)
status = 0;
before the "if (status)" check?
>
> list_for_each_entry(dev, &device->children, node) {
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
