Am Wed, 10 Oct 2012 15:16:59 -0700 schrieb Andrew Morton <a...@linux-foundation.org>:
> On Thu, 11 Oct 2012 00:04:07 +0200 > Richard Weinberger <rich...@nod.at> wrote: > > > commit 5ab1c30 (coredump: pass siginfo_t* to do_coredump() and > > below, not merely signr) added siginfo_t to linux/coredump.h but > > forgot to include asm/siginfo.h. This breaks the build for UML/i386. > > (And any other arch where asm/siginfo.h is not magically > > preincluded...) > > > > In file included from arch/x86/um/elfcore.c:2:0: > > include/linux/coredump.h:15:25: error: unknown type name 'siginfo_t' > > make[1]: *** [arch/x86/um/elfcore.o] Error 1 > > > > Cc: Denys Vlasenko <vda.li...@googlemail.com> > > Cc: Oleg Nesterov <o...@redhat.com> > > Cc: Amerigo Wang <amw...@redhat.com> > > Cc: "Jonathan M. Foote" <jmfo...@cert.org> > > Cc: Roland McGrath <rol...@hack.frob.com> > > Cc: Pedro Alves <pal...@redhat.com> > > Cc: Fengguang Wu <fengguang...@intel.com> > > Cc: Stephen Rothwell <s...@canb.auug.org.au> > > Cc: Andrew Morton <a...@linux-foundation.org> > > Signed-off-by: Richard Weinberger <rich...@nod.at> > > --- > > include/linux/coredump.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/coredump.h b/include/linux/coredump.h > > index 1775eb8..1d73993 100644 > > --- a/include/linux/coredump.h > > +++ b/include/linux/coredump.h > > @@ -4,6 +4,7 @@ > > #include <linux/types.h> > > #include <linux/mm.h> > > #include <linux/fs.h> > > +#include <asm/siginfo.h> > > > > /* > > * These are the only things you should do on a core-file: use > > only these > > hm, yes. It would be nice to jsut forward-declare the struct but we > can't do that because it's a pesky typedef. I know. :-\ > I wonder if it would be cleaner to just include linux/signal.h? > Diving down into the arch layer is a bit unusual. Doesn't matter, I > guess. I chose asm/siginfo.h because other users of siginfo_t also just include this file and linux/signal.h includes much more than we actually need... Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
