2012/10/12 5:31, David Rientjes wrote:
On Thu, 11 Oct 2012, Yasuaki Ishimatsu wrote:
When calling unregister_node(), the function shows following message at
device_release().
"Device 'node2' does not have a release() function, it is broken and must
be fixed."
The reason is node's device struct does not have a release() function.
So the patch registers node_device_release() to the device's release()
function for suppressing the warning message. Additionally, the patch adds
memset() to initialize a node struct into register_node(). Because the node
struct is part of node_devices[] array and it cannot be freed by
node_device_release(). So if system reuses the node struct, it has a garbage.
Nice catch on reuse of the statically allocated node_devices[] for node
hotplug.
CC: David Rientjes <[email protected]>
CC: Jiang Liu <[email protected]>
Cc: Minchan Kim <[email protected]>
CC: Andrew Morton <[email protected]>
CC: KOSAKI Motohiro <[email protected]>
Signed-off-by: Yasuaki Ishimatsu <[email protected]>
Signed-off-by: Wen Congyang <[email protected]>
Can register_node() be made static in drivers/base/node.c and its
declaration removed from linux/node.h?
Yah. I'll fix it.
Thanks,
Yasuaki Ishimatsu
Acked-by: David Rientjes <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
