On Mon, Oct 15, 2012 at 3:55 PM, Dave Chinner <da...@fromorbit.com> wrote:
> On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu <wu...@linux.vnet.ibm.com>
>>
>> Add a /sys/kernel/debug/hot_track/<device_name>/ directory for each
>> volume that contains two files. The first, `inode_data', contains the
>> heat information for inodes that have been brought into the hot data map
>> structures. The second, `range_data', contains similar information for
>> subfile ranges.
> ....
>> + /* create debugfs range_data file */
>> + debugfs_range_entry = debugfs_create_file("range_data",
>> + S_IFREG | S_IRUSR | S_IWUSR | S_IRUGO,
>> + debugfs_volume_entry,
>> + (void *) range_data,
>> + &hot_debugfs_range_fops);
>
> These should not be world readable. 0600 is probably the correct
> permissions for them as we do not want random users to be able to
> infer what files users are accessing from this information.
Good catch, its mode should be S_IFREG | S_IRUSR | S_IWUSR
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> da...@fromorbit.com
--
Regards,
Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
