On 10/14, Rabin Vincent wrote:
>
> @@ -655,6 +656,9 @@ do_work_pending(struct pt_regs *regs, unsigned int 
> thread_flags, int syscall)
>                                       return restart;
>                               }
>                               syscall = 0;
> +                     } else if (thread_flags & _TIF_UPROBE) {
> +                             clear_thread_flag(TIF_UPROBE);
> +                             uprobe_notify_resume(regs);
>                       } else {
>                               clear_thread_flag(TIF_NOTIFY_RESUME);
>                               tracehook_notify_resume(regs);

This doesn't look right. do_signal() can modify instruction pointer
after we hit the breakpoint. IOW, uprobe_notify_resume() should be
called before do_signal().

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to