Hi Jiri, > hci_ldisc's open checks if tty_struct->disc_data is set. And if so it > returns with an error. But nothing ensures disc_data to be NULL. And > since ld->ops->open shall be called only once, we do not need the > check at all. So remove it. > > Note that this is not an issue now, but n_tty will start using the > disc_data pointer and this invalid 'if' would trigger then rendering > TTYs over BT unusable. > > Signed-off-by: Jiri Slaby <jsl...@suse.cz> > Cc: Marcel Holtmann <mar...@holtmann.org> > Cc: Gustavo Padovan <gust...@padovan.org> > Cc: Johan Hedberg <johan.hedb...@gmail.com> > Cc: linux-blueto...@vger.kernel.org > --- > drivers/bluetooth/hci_ldisc.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-)
Acked-by: Marcel Holtmann <mar...@holtmann.org> Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
