On Thu, 18 Oct 2012 11:35:53 +0100
Ian Campbell <ian.campb...@citrix.com> wrote:
>
> > @@ -439,6 +490,19 @@ static long privcmd_ioctl(struct file *file,
> > return ret;
> > }
> >
> > +static void privcmd_close(struct vm_area_struct *vma)
> > +{
> > + struct page **pages = vma ? vma->vm_private_data : NULL;
>
> Can VMA really be NULL?...
Good programming I thought!
> > + int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
>
> ...I assume not since you unconditionally dereference it here.
Added this later, and just didn't change the earlier part.
> > + if (!pages || !numpgs
> > || !xen_feature(XENFEAT_auto_translated_physmap))
>
> In the non-xlat case pages will (or should!) be 1 here which will pass
> the first clause of the test.
>
> Although the later clauses will catch this I think it would be worth
> ordering the checks such that they are each valid, perhaps by pulling
> the feature check to the front or by separating the !xlat case from
> the other two which are valid iff xlat == True.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
