On Fri, Oct 19, 2012 at 12:54:02PM +0200, Linus Walleij wrote:
> The MVEBU driver probably just wants a few IRQs. Using the simple
> domain has the upside of allocating IRQ descriptors if need be,
> especially in a SPARSE_IRQ environment.
>
> Cc: Rob Herring <rob.herr...@calxeda.com>
> Cc: Grant Likely <grant.lik...@secretlab.ca>
> Cc: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselba...@gmail.com>
> Cc: Andrew Lunn <and...@lunn.ch>
> Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
> ---
> ChangeLog v1->v2:
> - Keep irq_create_mapping() and do not replace with
> irq_find_mapping() - if a linear domain is the outcome,
> we really need to allocate a descriptor on the first mapping
> call.
> ---
> drivers/gpio/gpio-mvebu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index 902af43..e0bde06 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -645,8 +645,8 @@ static int __devinit mvebu_gpio_probe(struct
> platform_device *pdev)
> IRQ_NOREQUEST, IRQ_LEVEL | IRQ_NOPROBE);
>
> /* Setup irq domain on top of the generic chip. */
> - mvchip->domain = irq_domain_add_legacy(np, mvchip->chip.ngpio,
> - mvchip->irqbase, 0,
> + mvchip->domain = irq_domain_add_simple(np, mvchip->chip.ngpio,
> + mvchip->irqbase,
> &irq_domain_simple_ops,
> mvchip);
> if (!mvchip->domain) {
> --
> 1.7.11.7
>
Hi Linus
I tested this on a kirkwood QNAP NAS box. gpio-keys still work and
generate interrupts etc.
Tested-by: Andrew Lunn <and...@lunn.ch>
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
