On 10/22/2012 02:14 AM, Linus Walleij wrote: > On Fri, Oct 19, 2012 at 6:22 PM, Stephen Warren <swar...@wwwdotorg.org> wrote: >> On 10/19/2012 09:09 AM, Linus Walleij wrote: >>> From: Linus Walleij <linus.wall...@linaro.org> >> >>> @@ -931,7 +931,7 @@ static void __nmk_gpio_irq_handler(unsigned int irq, >>> struct irq_desc *desc, >>> while (status) { >>> int bit = __ffs(status); >>> >>> - generic_handle_irq(irq_find_mapping(nmk_chip->domain, bit)); >>> + generic_handle_irq(irq_create_mapping(nmk_chip->domain, bit)); >> >> Surely this one can remain as irq_find_mapping() since isn't >> nmk_gpio_to_irq() guaranteed to have been called first for this GPIO/IRQ? > > It's an IRQ handler so it should be robust to spurious IRQs due to > transient hardware states etc I believe. > > So if there is a transient IRQ before gpio_to_irq() is called -> boom.
I wonder though (a) why it would be unmasked in HW, and (b) why the software would even look at the status bit if no handler were registered? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/