On Tue, Oct 23, 2012 at 06:34:33PM +0800, Miao Xie wrote: > So we add this WARN_ON_ONCE(), it can tell the developers that there > is something wrong in the code if it is triggered.
First of all, the WARN_ON_ONCE will fire only once during system lifetime (well, doh, of course) which diminishes debuggability significantly and then, the only other place which deals with CPU_POST_DEAD is kernel/stop_machine.c:cpu_stop_cpu_callback. So, just to sum up and finish this fruitless discussion: cmci_rediscover() correctly ignores the dying cpu and there's *absolutely* no need to warn. If you still think there is, you have to come up with a concrete example and a way for others to reproduce it. Then we can talk. End of story. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
