On Wed, 24 Oct 2012 14:26:13 -0400
Ed Cashin <ecas...@coraid.com> wrote:
> After calling dev_queue_xmit it is no longer safe to access the
> members of the skb.
>
> Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
hm, that was clever. How did Dan detect this bug?
> --- a/drivers/block/aoe/aoenet.c
> +++ b/drivers/block/aoe/aoenet.c
> @@ -55,12 +55,14 @@ static int
> tx(void) __must_hold(&txlock)
> {
> struct sk_buff *skb;
> + struct net_device *ifp;
>
> while ((skb = skb_dequeue(&skbtxq))) {
> spin_unlock_irq(&txlock);
> + ifp = skb->dev;
> if (dev_queue_xmit(skb) == NET_XMIT_DROP && net_ratelimit())
> pr_warn("aoe: packet could not be sent on %s. %s\n",
> - skb->dev ? skb->dev->name : "netif",
> + ifp ? ifp->name : "netif",
> "consider increasing tx_queue_len");
> spin_lock_irq(&txlock);
> }
Queued as a fix against the not-yet-upstream
aoe-print-warning-regarding-a-common-reason-for-dropped-transmits.patch,
thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
