Hi, Greg Kroah-Hartman wrote:
> commit 31fd84b95eb211d5db460a1dda85e004800a7b52 upstream. > > The min/max call needed to have explicit types on some architectures > (e.g. mn10300). Use clamp_t instead to avoid the warning: > > kernel/sys.c: In function 'override_release': > kernel/sys.c:1287:10: warning: comparison of distinct pointer types lacks a > cast [enabled by default] > > Reported-by: Fengguang Wu <fengguang...@intel.com> > Signed-off-by: Kees Cook <keesc...@chromium.org> > Signed-off-by: Linus Torvalds <torva...@linux-foundation.org> > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> [...] > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -1152,7 +1152,7 @@ static int override_release(char __user > rest++; > } > v = ((LINUX_VERSION_CODE >> 8) & 0xff) + 40; > - copy = min(sizeof(buf), max_t(size_t, 1, len)); > + copy = clamp_t(size_t, len, 1, sizeof(buf)); > copy = scnprintf(buf, copy, "2.6.%u%s", v, rest); Does this have any effect at runtime? If not, why is it needed for stable kernels? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
