On Sat, Oct 27, 2012 at 01:55:44AM +0800, Yan Hong wrote:
>
> Signed-off-by: Yan Hong <clouds....@gmail.com>
> ---
> fs/debugfs/file.c | 42 ++++++++++++++++++++++++++++--------------
> fs/debugfs/inode.c | 10 ++++++----
> 2 files changed, 34 insertions(+), 18 deletions(-)
>
> diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
> index 3915cc9..b37eee1 100644
> --- a/fs/debugfs/file.c
> +++ b/fs/debugfs/file.c
> @@ -95,10 +95,12 @@ struct dentry *debugfs_create_u8(const char *name,
> umode_t mode,
> {
> /* if there are no write bits set, make read only */
> if (!(mode & S_IWUGO))
> - return debugfs_create_file(name, mode, parent, value,
> &fops_u8_ro);
> + return debugfs_create_file(name, mode, parent, value,
> + &fops_u8_ro);
If you are going to do this (and hint, I really don't want you to), at
least make it look pretty:
return debugfs_create_file(name, mode, parent, value,
&fops_u8_ro);
Other than that, I don't want to take this patch, sorry, it looks good
enough as-is.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
