On 10/26/2012 06:30 AM, Jingoo Han wrote: > This patch adds missing device.h header to fix build warnings as below: > > drivers/cpuidle/cpuidle.h:26:41: warning: 'struct device' declared inside > parameter list [enabled by default] > drivers/cpuidle/cpuidle.h:26:41: warning: its scope is only this definition > or declaration, which is probably not what you want > [enabled by default] > drivers/cpuidle/cpuidle.h:27:45: warning: 'struct device' declared inside > parameter list [enabled by default] > In file included from drivers/cpuidle/driver.c:15:0: > drivers/cpuidle/cpuidle.h:26:41: warning: 'struct device' declared inside > parameter list [enabled by default] > drivers/cpuidle/cpuidle.h:26:41: warning: its scope is only this definition > or declaration, which is probably not what you want > [enabled by default] > drivers/cpuidle/cpuidle.h:27:45: warning: 'struct device' declared inside > parameter list [enabled by default] > > This build warning is introduced by commit efeca1b > "cpuidle / sysfs: change function parameter". > > Signed-off-by: Jingoo Han <jg1....@samsung.com> > Cc: Daniel Lezcano <daniel.lezc...@linaro.org> > ---
Jingoo, could you copy-pastebin your config file. I don't have this warning and I would like to understand why. Thanks -- Daniel > drivers/cpuidle/cpuidle.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle.h b/drivers/cpuidle/cpuidle.h > index a5bbd1c..2120d9e 100644 > --- a/drivers/cpuidle/cpuidle.h > +++ b/drivers/cpuidle/cpuidle.h > @@ -5,6 +5,8 @@ > #ifndef __DRIVER_CPUIDLE_H > #define __DRIVER_CPUIDLE_H > > +#include <linux/device.h> > + > /* For internal use only */ > extern struct cpuidle_governor *cpuidle_curr_governor; > extern struct list_head cpuidle_governors; -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
