On Mon, Oct 29, 2012 at 01:43:25PM +0100, Oleg Nesterov wrote: > On 10/29, Ananth N Mavinakayanahalli wrote: > > > > On Sun, Oct 28, 2012 at 06:39:25PM +0100, Oleg Nesterov wrote: > > > > Hi Oleg, > > > > > Cleanup. No need to clear TIF_UPROBE, do_notify_resume() does this. > > > > > > Signed-off-by: Oleg Nesterov <o...@redhat.com> > > > --- > > > arch/powerpc/kernel/signal.c | 4 +--- > > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c > > > index a2dc757..3b99711 100644 > > > --- a/arch/powerpc/kernel/signal.c > > > +++ b/arch/powerpc/kernel/signal.c > > > @@ -158,10 +158,8 @@ static int do_signal(struct pt_regs *regs) > > > > > > void do_notify_resume(struct pt_regs *regs, unsigned long > > > thread_info_flags) > > > > But this _is_ do_notify_resume()... > > Argh. I'll fix the changelog, see v2 below. > > > I don't see this flag cleared > > anywhere else. > > > > Did you have something else in mind? > > Sorry for confusion. > > As Srikar explained, it is cleared by uprobe_notify_resume(). See db023ea5 > "uprobes: Move clear_thread_flag(TIF_UPROBE) to uprobe_notify_resume()", it > is already in Linus's tree.
I was looking at rc2.. that explains it. > Oleg. > > ------------------------------------------------------------------------------ > Subject: [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in > do_notify_resume() > > Cleanup. No need to clear TIF_UPROBE, uprobe_notify_resume() does this. > > Signed-off-by: Oleg Nesterov <o...@redhat.com> Acked-by: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Thanks Oleg! Ananth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/