> --- a/kernel/fork.c~fork-unshare-remove-dead-code
> +++ a/kernel/fork.c
> @@ -1792,10 +1792,8 @@ SYSCALL_DEFINE1(unshare, unsigned long,
> exit_sem(current);
> }
>
> - if (new_nsproxy) {
> + if (new_nsproxy)
> switch_task_namespaces(current, new_nsproxy);
> - new_nsproxy = NULL;
> - }
>
> task_lock(current);
>
> @@ -1819,9 +1817,6 @@ SYSCALL_DEFINE1(unshare, unsigned long,
> task_unlock(current);
> }
>
> - if (new_nsproxy)
> - put_nsproxy(new_nsproxy);
> -
Agreed.
Perhaps it also makes sense to kill
"if (new_fs || new_fd || do_sysvsem || new_nsproxy)" ? This check
buys nothing. And without this check it is obvious why we do not
need put_nsproxy() after this block.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
