On Thu, Nov 1, 2012 at 1:33 PM, Russell King - ARM Linux
<li...@arm.linux.org.uk> wrote:
> It's pointless having:
>
> tst r10, #_TIF_SECCOMP
> bne __sys_trace
> tst r10, #_TIF_SYSCALL_WORK
> bne __sys_trace
>
> Instead, make TIF_SECCOMP be bit 11, combine it into _TIF_SYSCALL_WORK, and
> eliminate all of that CONFIG_SECCOMP block.
Ah! Good point; I'd missed that _WORK was a bit field. I'll make those changes.
>> diff --git a/arch/arm/kernel/ptrace.c b/arch/arm/kernel/ptrace.c
>> index 739db3a..6b0e14b 100644
>> --- a/arch/arm/kernel/ptrace.c
>> +++ b/arch/arm/kernel/ptrace.c
>> @@ -916,13 +916,15 @@ enum ptrace_syscall_dir {
>> PTRACE_SYSCALL_EXIT,
>> };
>>
>> -static int ptrace_syscall_trace(struct pt_regs *regs, int scno,
>> - enum ptrace_syscall_dir dir)
>> +asmlinkage int syscall_trace_enter(struct pt_regs *regs, int scno)
>
> I'm not sure this change is correct (combined with your hunk below).
> What if we have auditing enabled but trace disabled? How do we reach
> audit_syscall_entry()? Or the tracehook stuff?
>
> This patch looks wrong in too many ways.
Oh, yeah, you're totally right. I will fix that up. Thanks!
-Kees
--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
