On Fri, Nov 02, 2012 at 05:31:36PM +0800, Robin Dong wrote: > From: Robin Dong <san...@taobao.com> > > We don't need to convert tg to blkg and then convert it back in > throtl_update_dispatch_stats(). > > Signed-off-by: Robin Dong <san...@taobao.com> > ---
Looks good to me. Acked-by: Vivek Goyal <vgo...@redhat.com> Vivek > block/blk-throttle.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/block/blk-throttle.c b/block/blk-throttle.c > index a9664fa..46ddeff 100644 > --- a/block/blk-throttle.c > +++ b/block/blk-throttle.c > @@ -674,10 +674,9 @@ static bool tg_may_dispatch(struct throtl_data *td, > struct throtl_grp *tg, > return 0; > } > > -static void throtl_update_dispatch_stats(struct blkcg_gq *blkg, u64 bytes, > +static void throtl_update_dispatch_stats(struct throtl_grp *tg, u64 bytes, > int rw) > { > - struct throtl_grp *tg = blkg_to_tg(blkg); > struct tg_stats_cpu *stats_cpu; > unsigned long flags; > > @@ -708,7 +707,7 @@ static void throtl_charge_bio(struct throtl_grp *tg, > struct bio *bio) > tg->bytes_disp[rw] += bio->bi_size; > tg->io_disp[rw]++; > > - throtl_update_dispatch_stats(tg_to_blkg(tg), bio->bi_size, bio->bi_rw); > + throtl_update_dispatch_stats(tg, bio->bi_size, bio->bi_rw); > } > > static void throtl_add_bio_tg(struct throtl_data *td, struct throtl_grp *tg, > @@ -1127,7 +1126,7 @@ bool blk_throtl_bio(struct request_queue *q, struct bio > *bio) > tg = throtl_lookup_tg(td, blkcg); > if (tg) { > if (tg_no_rule_group(tg, rw)) { > - throtl_update_dispatch_stats(tg_to_blkg(tg), > + throtl_update_dispatch_stats(tg, > bio->bi_size, bio->bi_rw); > goto out_unlock_rcu; > } > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/