The main issue is that bit(n) is defined as:
(u32)1 << n
Thus bit(n) with n >= 32 will produce 0 or 1, depending on the
architecture. This is also undefined behavior in C.
The OR with sata_reg_set (u64) then doesn't work because bit()
does a 32-bit shift, which should have been a 64-bit shift:
if (i >= 32) {
mvi->sata_reg_set |= bit(i);
...
}
The other two patches fix similar oversized shift issues.
Xi Wang (3):
[SCSI] mvsas: fix shift in mvs_94xx_assign_reg_set()
[SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()
[SCSI] mvsas: fix shift in mv_ffc64()
drivers/scsi/mvsas/mv_94xx.c | 8 +++++---
drivers/scsi/mvsas/mv_94xx.h | 14 ++------------
drivers/scsi/mvsas/mv_sas.h | 2 +-
3 files changed, 8 insertions(+), 16 deletions(-)
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
