> -----Original Message----- > From: Tomas Hozza [mailto:[email protected]] > Sent: Thursday, November 08, 2012 9:53 AM > To: Olaf Hering > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; KY > Srinivasan > Subject: Re: [PATCH] Tools: hv: Fix for long file names from readdir > > > > - char dev_id[256]; > > > + char dev_id[512]; > > > > Shouldnt that be PATH_MAX or similar? > > dirent->d_name should be PATH_MAX, but it is mostly > not guaranteed. And then the dev_id is concatenated > with two strings so it can exceed 256 bytes.
PATH_MAX (currently 4096 bytes) I think should suffice. Regards, K. Y
