On Thursday 08 November 2012, Sasha Levin wrote: > Just use BUG_ON() instead of constructions such as: > > if (...) > BUG() > > A simplified version of the semantic patch that makes this transformation > is as follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e; > @@ > - if (e) BUG(); > + BUG_ON(e); > // </smpl> > > Signed-off-by: Sasha Levin <[email protected]>
Linus Walleij is doing most of the integrator work these days, maybe he wants to apply the patch. Acked-by: Arnd Bergmann <[email protected]> > arch/arm/mach-integrator/pci_v3.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/mach-integrator/pci_v3.c > b/arch/arm/mach-integrator/pci_v3.c > index bbeca59..85938de 100644 > --- a/arch/arm/mach-integrator/pci_v3.c > +++ b/arch/arm/mach-integrator/pci_v3.c > @@ -191,12 +191,9 @@ static void __iomem *v3_open_config_window(struct > pci_bus *bus, > /* > * Trap out illegal values > */ > - if (offset > 255) > - BUG(); > - if (busnr > 255) > - BUG(); > - if (devfn > 255) > - BUG(); > + BUG_ON(offset > 255); > + BUG_ON(busnr > 255); > + BUG_ON(devfn > 255); > > if (busnr == 0) { > int slot = PCI_SLOT(devfn); > -- > 1.7.10.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
