2012/11/14 Steven Rostedt <[email protected]>: > On Wed, 2012-11-14 at 17:26 +0100, Frederic Weisbecker wrote: >> vtime_account() is only called from irq entry. irqs >> are always disabled at this point so we can safely >> remove the irq disabling guards on that function. >> >> Signed-off-by: Frederic Weisbecker <[email protected]> >> Cc: Peter Zijlstra <[email protected]> >> Cc: Ingo Molnar <[email protected]> >> Cc: Thomas Gleixner <[email protected]> >> Cc: Steven Rostedt <[email protected]> >> Cc: Paul Gortmaker <[email protected]> >> Cc: Tony Luck <[email protected]> >> Cc: Fenghua Yu <[email protected]> >> Cc: Benjamin Herrenschmidt <[email protected]> >> Cc: Paul Mackerras <[email protected]> >> Cc: Martin Schwidefsky <[email protected]> >> Cc: Heiko Carstens <[email protected]> >> --- >> kernel/sched/cputime.c | 6 ------ >> 1 files changed, 0 insertions(+), 6 deletions(-) >> >> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c >> index 2e8d34a..80b2fd5 100644 >> --- a/kernel/sched/cputime.c >> +++ b/kernel/sched/cputime.c >> @@ -467,16 +467,10 @@ void vtime_task_switch(struct task_struct *prev) >> #ifndef __ARCH_HAS_VTIME_ACCOUNT >> void vtime_account(struct task_struct *tsk) >> { >> - unsigned long flags; >> - >> - local_irq_save(flags); >> - > > I'd add a WARN_ON_ONCE(!irqs_disabled()) again here, or is this also > covered by the vtime_delta()?
Yeah it's the ending point for both vtime_account_system() and vtime_account_idle() -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
