2012/11/15 15:59, Wen Congyang wrote: > If acpi_memory_enable_device() fails, acpi_memory_enable_device() will > return a non-zero value, which means we fail to bind the memory device to > this driver. So we should free memory device before > acpi_memory_device_add() returns. > > CC: David Rientjes <[email protected]> > CC: Jiang Liu <[email protected]> > CC: Len Brown <[email protected]> > CC: Benjamin Herrenschmidt <[email protected]> > CC: Paul Mackerras <[email protected]> > CC: Christoph Lameter <[email protected]> > Cc: Minchan Kim <[email protected]> > CC: Andrew Morton <[email protected]> > CC: KOSAKI Motohiro <[email protected]> > CC: Yasuaki Ishimatsu <[email protected]> > CC: Rafael J. Wysocki <[email protected]> > CC: Konrad Rzeszutek Wilk <[email protected]> > Signed-off-by: Wen Congyang <[email protected]> > ---
Reviewed-by: Yasuaki Ishimatsu <[email protected]> Thanks, Yasuaki Ishimatsu > drivers/acpi/acpi_memhotplug.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > index c5e7b6d..e52ad5d 100644 > --- a/drivers/acpi/acpi_memhotplug.c > +++ b/drivers/acpi/acpi_memhotplug.c > @@ -421,9 +421,11 @@ static int acpi_memory_device_add(struct acpi_device > *device) > if (!acpi_memory_check_device(mem_device)) { > /* call add_memory func */ > result = acpi_memory_enable_device(mem_device); > - if (result) > + if (result) { > printk(KERN_ERR PREFIX > "Error in acpi_memory_enable_device\n"); > + acpi_memory_device_free(mem_device); > + } > } > return result; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
