On 15 November 2012 11:39, Ohad Ben-Cohen <o...@wizery.com> wrote: >> I do agree description is missing, again I thought I had done this >> somewhere but looks like I didn't, will update these. If you think >> these should be different patches please let me know, otherwise I >> would like to keep a single *documented* patch. > > It seems like there are 3 different logical changes here: > > 1. remove clk_* invocations from iommu_fault_handler() > 2. keep clocks enabled as long as iommu is enabled > 3. convert to runtime pm > > If we split this to three patches in this order, you won't have to add > and remove runtime pm functions. > > Let's do it, please. It's a small nuisance now, but may be really > helpful in the future when someone tries to debug stuff and understand > the motivation behind these changes. It'd make it much easier for you > to document the changes, too: you have an entire commit log per > change.
Ok, not a problem then. Cheers, Omar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
