Hi Alex, On 11/17/2012 06:34 PM, Alex Shi wrote: > Except using runnable load average in background, wake_affine and > move_tasks is also the key functions in load balance. We need consider > the runnable load average in them in order to the apple to apple load > comparison in load balance. > > Signed-off-by: Alex Shi <alex....@intel.com> > --- > kernel/sched/fair.c | 16 ++++++++++------ > 1 files changed, 10 insertions(+), 6 deletions(-) > > @@ -4229,7 +4233,7 @@ static int move_tasks(struct lb_env *env) > if (throttled_lb_pair(task_group(p), env->src_cpu, > env->dst_cpu)) > goto next; > > - load = task_h_load(p); > + load = task_h_load(p) * p->se.avg.load_avg_contrib; Shouldn't the above be just load = p->se.avg.load_avg_contrib? This metric already has considered p->se.load.weight.task_h_load(p) returns the same. > > if (sched_feat(LB_MIN) && load < 16 && !env->failed) > goto next; > Regards Preeti U Murthy
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
