On Thu, Oct 18, 2012 at 02:06:03PM +0300, dragos.tatu...@intel.com wrote: > From: Dragos Tatulea <dragos.tatu...@intel.com> > > The task dumper can dump task information during a panic. > This is equivalent to a magic sysrq 't' command but > the result is captured from the console and written > to persistent storage. Note that this happens after > pstore dumps kernel messages because the task dump will > overwrite other kernel messages. > > There is a single module parameter "enabled" which must > be used to enable task dumping.
This is a very very strange approach to accomplish this. Plus, we have the console dumper already, so I think it should be done the other way around: if you want a tasklist dumped during panic, introduce a generic feature for the panic logging, i.e. just print tasks after/before panic trace. Or am I missing the point of the patch? > > Signed-off-by: Adrian Hunter <adrian.hun...@intel.com> > Signed-off-by: Dragos Tatulea <dragos.tatu...@intel.com> > --- > fs/pstore/Kconfig | 12 ++++++ > fs/pstore/Makefile | 1 + > fs/pstore/dump_tasks.c | 107 > ++++++++++++++++++++++++++++++++++++++++++++++++ > fs/pstore/inode.c | 3 ++ > include/linux/pstore.h | 1 + > 5 files changed, 124 insertions(+) > create mode 100644 fs/pstore/dump_tasks.c > > diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig > index ca71db6..ee967c5 100644 > --- a/fs/pstore/Kconfig > +++ b/fs/pstore/Kconfig > @@ -48,3 +48,15 @@ config PSTORE_RAM > "ramoops.ko". > > For more information, see Documentation/ramoops.txt. > + > +config PSTORE_DUMP_TASKS > + bool "Dump task information" > + default n 'default n' is there by default. :) So no need for this line. Thanks, Anton. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
