On Mon, 26 Nov 2012, Viresh Kumar wrote: > On 26 November 2012 18:55, Lee Jones <lee.jo...@linaro.org> wrote: > > > Why do you need to sort them? Is there _really_ a need? > > Many people & maintainers like to have their header files ordered. The > reason for that is: > > If they are not ordered, there is a possibility of adding an header file > multiple times in a file. This might not do something serious > when thinking about compilation time or Image size, but adding an header > file multiple times is simply wrong. > > This can't be caught in patch reviews most of the time, as diff may not show > the earlier inclusion. > > That's why i ordered them. And i don't see any harm in doing so.
I don't see any harm in it, but it's pretty pointless. There aren't many maintainers who insist on such things, and the ones that do normally carry out these OCD actions themselves. :) -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
