On Wed, 28 Nov 2012, Viresh Kumar wrote: > On 28 November 2012 01:25, Rabin Vincent <ra...@rab.in> wrote: > > 2012/11/27 Viresh Kumar <viresh.ku...@linaro.org>: > >> On 27 November 2012 14:10, Lee Jones <lee.jo...@linaro.org> wrote: > >> I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin > >> would have, that's why he added that part of code :) > >> > >> @Rabin/Linus: Do you remember why have you added this in stmpe driver: > >> > >> + if (stmpe->pdata->irq_invert_polarity) > >> + icr ^= STMPE_ICR_LSB_HIGH; > >> + > >> > >> Does somebody actually need it? > > > > It was (as irq_rev_pol) part of Luotao Fu's proposed STMPE811 patchset > > (https://patchwork.kernel.org/patch/106173/) which I integrated into my > > version of the STMPE driver, which didn't have it in its initial version > > (https://patchwork.kernel.org/patch/103273/). > > > > It's not something _I_ ever used. > > I grep'd kernel and nobody is using it there, so lets get rid of it > completely :) > I will patch it.
Great. :) -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/