On Wed, 28 Nov 2012 22:45:34 +0100 Krzysztof Mazur <krzys...@podlesie.net> wrote:
> On Wed, Nov 28, 2012 at 04:20:01PM -0500, chas williams - CONTRACTOR wrote: > > i dont like the vcc->pop() implementation and at one point i had the > > crazy idea of using skb->destructors to handle it. however, i think it > > would be necessary to clone the skb's so any existing destructor is > > preserved. > > With this patch we will kill vcc->pop() in drivers and in future > we can do that without changes in drivers. ok > > > > > +#define vcc_pop(vcc, skb) vcc_pop_any(vcc, skb) > > > +#define vcc_pop_irq(vcc, skb) vcc_pop_any(vcc, skb) > > > > don't define these if you dont plan on using them anway. > > I removed them. I also added check if vcc is NULL, as David Woodhouse > suggested, some drivers use that. it should probably be if (likely(vcc) && likely(vcc->pop)) since it will almost always be the case. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
