On Fri, 30 Nov 2012, Samuel Ortiz wrote: > Hi Viresh, Lee, > > On Thu, Nov 29, 2012 at 08:10:18PM +0530, Viresh Kumar wrote: > > From: Vipul Kumar Samar <vipulkumar.sa...@st.com> > > > > This patch extends existing DT support for stmpe devices. This updates: > > - DT support from stmpe SPI and I2C drivers > > - missing header files in stmpe.c > > - stmpe_of_probe() with pwm, rotator and new bindings. > > - Bindings are updated in binding document. > > > > Signed-off-by: Vipul Kumar Samar <vipulkumar.sa...@st.com> > > Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> > > --- > > V4->V5: > > ------ > > - 2/3 and 3/3 merged. > > - irq_trigger is kept same for non-DT booti. > > > > @Lee: I haven't added your Acked-by, because this differs from your Acked > > version. > Lee, are you ok with this one ? Could you give it a test ?
Okay, I've tested it, and it doesn't break anything. But ... I don't see how the changes in the -i2c and -spi files are of benefit either. When I boot without the ID table I still get "stmpe-i2c 0-0040: stmpe1601 detected, chip id: 0x212". What is it that actually uses the IDs? Perhaps Viresh can shine some light on the matter? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
