> + ret = cpulist_parse(buf, newmask);
> + if (!ret) {
> + spin_lock(&bdi->wb_lock);
> + task = wb->task;
> + get_task_struct(task);
> + spin_unlock(&bdi->wb_lock);
> + if (task)
> + ret = set_cpus_allowed_ptr(task, newmask);
> + put_task_struct(task);
If that test for a non-null task is needed then surely the get and put
need to be similarly protected :).
> + bdi->flusher_cpumask = kmalloc(sizeof(cpumask_t), GFP_KERNEL);
> + if (!bdi->flusher_cpumask)
> + return -ENOMEM;
The bare GFP_KERNEL raises an eyebrow. Some bdi_init() callers like
blk_alloc_queue_node() look like they'll want to pass in a gfp_t for the
allocation.
And shouldn't this be freed in the error path of bdi_init()?
- z
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
