From: Philippe Reynes <[email protected]>
Date: Sat, 1 Dec 2012 21:44:49 +0100
> static int smsc_phy_config_init(struct phy_device *phydev)
> {
> - int rc = phy_read(phydev, MII_LAN83C185_CTRL_STATUS);
> + /*
> + * If the SMSC PHY is in power down mode, then set it
> + * in all capable mode before using it.
> + */
> + int rc = phy_read(phydev, MII_LAN83C185_SPECIAL_MODES);
This is formatted poorly. Do not put comments above the basic
block variable declarations, it looks terrible.
Also, comments in the networking code should be formatted:
/* Like
* this.
*/
/*
* Not like
* this.
*/
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
